[SPARK-21634][SQL] Change OneRowRelation from a case object to case class#18839
Closed
rxin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-21634][SQL] Change OneRowRelation from a case object to case class#18839rxin wants to merge 1 commit intoapache:masterfrom
rxin wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Some test on string form of the plan might fail. Let's see ... |
|
Test build #80231 has finished for PR 18839 at commit
|
Contributor
Author
|
cc @gatorsmile |
gatorsmile
approved these changes
Aug 4, 2017
Member
|
LGTM. Merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OneRowRelation is the only plan that is a case object, which causes some issues with makeCopy using a 0-arg constructor. This patch changes it from a case object to a case class.
This blocks SPARK-21619.
How was this patch tested?
Should be covered by existing test cases.